mstorsjo wrote:

Thanks! That seems to work great!

However - that uncovers a case in the existing tests in this PR, which starts 
failing:
```
#pragma ms_struct on
struct {  
    int a : 24;
    char b : 8;
} __attribute__((gcc_struct)) t2;
_Static_assert(sizeof(t2) == 4, "");
#pragma ms_struct off      
```
This now also hits the same error with incompatible attributes. This is a case 
I think should be supported; just like `-mms-bitfields` or `-mno-ms-bitfields`, 
such a pragma sets the default over a region, while one may want to override 
the default for specific structs.

https://github.com/llvm/llvm-project/pull/71148
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to