llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Brad Smith (brad0) <details> <summary>Changes</summary> Remove the llvm_unreachable from getDynamicLinker(). The code path is reachable. In the case of an unsupported architecture we're not worrying about trying to actually determine the dynamic linker, and I don't think it makes sense for the Driver to crash. Pointed out by bug report #<!-- -->64194 --- Full diff: https://github.com/llvm/llvm-project/pull/171077.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/Hurd.cpp (+1-1) ``````````diff diff --git a/clang/lib/Driver/ToolChains/Hurd.cpp b/clang/lib/Driver/ToolChains/Hurd.cpp index 53ee4d4c0cbde..b2c887fb72671 100644 --- a/clang/lib/Driver/ToolChains/Hurd.cpp +++ b/clang/lib/Driver/ToolChains/Hurd.cpp @@ -160,7 +160,7 @@ std::string Hurd::getDynamicLinker(const ArgList &Args) const { break; } - llvm_unreachable("unsupported architecture"); + return ""; } void Hurd::AddClangSystemIncludeArgs(const ArgList &DriverArgs, `````````` </details> https://github.com/llvm/llvm-project/pull/171077 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
