lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.
Otherwise this looks good to me.
================
Comment at: examples/clang-interpreter/CMakeLists.txt:73
+ set_property(TARGET ${TARGET} PROPERTY COMPILE_FLAGS ${editedFlags})
+ #message("COMPILE_FLAGS: '${addedFlags}' '${editedFlags}'")
+
----------------
These debugging messages (this and the one below) should probably be stripped.
================
Comment at: examples/clang-interpreter/Invoke.h:10
+
+#pragma once
+
----------------
I believe you should use include guards in LLVM headers. Pragma once should
work, but I don't think it's standard (and it doesn't seem to be used anywhere
else in the codebase).
================
Comment at: examples/clang-interpreter/Manager.h:10
+
+#pragma once
+
----------------
Ditto here.
https://reviews.llvm.org/D35103
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
