[PATCH] D35790: [clang-tidy] Handle incomplete types in bugprone-undefined-memory-manipulation check.

[Phabricator via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL308954: [clang-tidy] Handle incomplete types in 
bugprone-undefined-memory-manipulation (authored by xazax).

Changed prior to commit:
  https://reviews.llvm.org/D35790?vs=107863&id=108012#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D35790

Files:
  
clang-tools-extra/trunk/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
  
clang-tools-extra/trunk/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp


Index: 
clang-tools-extra/trunk/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
===================================================================
--- 
clang-tools-extra/trunk/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
+++ 
clang-tools-extra/trunk/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
@@ -19,7 +19,8 @@
 
 namespace {
 AST_MATCHER(CXXRecordDecl, isNotTriviallyCopyable) {
-  return !Node.isTriviallyCopyable();
+  // For incomplete types, assume they are TriviallyCopyable.
+  return Node.hasDefinition() ? !Node.isTriviallyCopyable() : false;
 }
 } // namespace
 
Index: 
clang-tools-extra/trunk/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
===================================================================
--- 
clang-tools-extra/trunk/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
+++ 
clang-tools-extra/trunk/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
@@ -52,6 +52,13 @@
   int vb;
 };
 
+// Incomplete type, assume it is TriviallyCopyable.
+struct NoDef;
+
+void f(NoDef *s) {
+  memset(s, 0, 5);
+}
+
 template <typename T>
 void memset_temp(T *b) {
   memset(b, 0, sizeof(T));



Index: clang-tools-extra/trunk/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
===================================================================
--- clang-tools-extra/trunk/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
+++ clang-tools-extra/trunk/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
@@ -19,7 +19,8 @@
 
 namespace {
 AST_MATCHER(CXXRecordDecl, isNotTriviallyCopyable) {
-  return !Node.isTriviallyCopyable();
+  // For incomplete types, assume they are TriviallyCopyable.
+  return Node.hasDefinition() ? !Node.isTriviallyCopyable() : false;
 }
 } // namespace
 
Index: clang-tools-extra/trunk/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
===================================================================
--- clang-tools-extra/trunk/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
+++ clang-tools-extra/trunk/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
@@ -52,6 +52,13 @@
   int vb;
 };
 
+// Incomplete type, assume it is TriviallyCopyable.
+struct NoDef;
+
+void f(NoDef *s) {
+  memset(s, 0, 5);
+}
+
 template <typename T>
 void memset_temp(T *b) {
   memset(b, 0, sizeof(T));

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits