malhar1995 added inline comments.
================
Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:2012
+ } else if (CurrV.getObjKind() == RetEffect::GenericC) {
+ if (Sym->getType().isNull()) {
+ os << " returns an object with a ";
----------------
NoQ wrote:
> I don't think this can happen. Symbols always have a type, see
> `isValidTypeForSymbol()`. These branches can be removed from the surrounding
> code as well.
So, you're saying `Sym->getType()` can never be NULL?
If so, do you want me to insert `assert(isValidTypeForSymbol(Sym->getType()))`
instead?
Repository:
rL LLVM
https://reviews.llvm.org/D35613
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
