malhar1995 added a comment. In https://reviews.llvm.org/D34937#811500, @dcoughlin wrote:
> Looks good to me, other than a nit on indentation and a request for a little > bit more info in a comment! Currently, I have added support for generic annotations for __isl_take and __isl_give and I have also added a generic diagnostic note when the function returns an object which is neither Core-Foundation nor Objective-C. For emitting a generic diagnostic note, I have added an object kind to the enum ObjKind in ObjCRetainCount.h. Now, for adding the aforementioned support, I have made some changes to the patch which I last submitted. So, should I submit another patch on the same revision after modifying the title, summary, etc. or should I create another revision for that? Repository: rL LLVM https://reviews.llvm.org/D34937 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
