https://github.com/OCHyams approved this pull request.

> Here's a new round of compile time 
> [results](http://llvm-compile-time-tracker.com/compare.php?from=34a34888152388c91dd66c10eefd600b3200e779&to=15cfbe5ae7d4ff4a48a648a9f5fa54404d5b3846&stat=instructions%3Au)
>  after lifting up the call site emission conditions check.

> We're now doing less work on average for many O0 debug runs since we're 
> checking whether to emit earlier than the previous version did. The O3 debug 
> run continues to show a slight increase above baseline, but that's expected 
> since there's a bit more call site emission work happening in optimised debug 
> runs.

> Please take a look and let me know if this round looks good to you as well.

Excellent, LGTM! Thanks for digging into that.

https://github.com/llvm/llvm-project/pull/166202
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to