https://github.com/Sirraide commented:
LGTM One thing I forgot to mention with the other function effects prs: we should add a release note for them. It doesn’t have to be anything too specific; just something along the lines of ‘Fixed a number of false positives and false negatives around `-Wfunction-effects`’ is enough imo. https://github.com/llvm/llvm-project/pull/166110 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
