rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land.
LGTM, thanks! I'm not particularly happy with the number of different places where we duplicate the knowledge of how break/continue bind to enclosing loops, but fixing that seems beyond the scope of this change. ================ Comment at: lib/Sema/SemaStmt.cpp:1610 + Visit(End); + } + ---------------- In CodeGen, we don't evaluate the condition within the continue/break scope of the loop... but I'm pretty sure that doesn't matter because only the range statement can contain a break or continue anyway. Repository: rL LLVM https://reviews.llvm.org/D34568 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
