alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed.
================ Comment at: clang-tidy/modernize/MakeSmartPtrCheck.h:28 MakeSmartPtrCheck(StringRef Name, ClangTidyContext *Context, - std::string makeSmartPtrFunctionName); + StringRef makeSmartPtrFunctionName); void registerMatchers(ast_matchers::MatchFinder *Finder) final; ---------------- s/makeSmartPtr/MakeSmartPtr/ here and below. ================ Comment at: test/clang-tidy/modernize-make-shared-header.cpp:1 +// RUN: cp %S/Inputs/modernize-smart-ptr/shared_ptr.h %T/shared_ptr.h +// RUN: %check_clang_tidy %s modernize-make-shared %t -- \ ---------------- Maybe just add "-I%S/Inputs/modernize-smart-ptr/" flag to the clang-tidy invocation? https://reviews.llvm.org/D34206 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
