alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed.
Please re-upload the patch with full context (see http://llvm.org/docs/Phabricator.html). ================ Comment at: lib/Tooling/CommonOptionsParser.cpp:119 cl::HideUnrelatedOptions(Category); - + //Expand response files before loading compilation database from command line + SmallVector<const char *, 20> newArgv(argv, argv + argc); ---------------- Add a space after `//` and a trailing period. ================ Comment at: unittests/Tooling/CommonOptionsParserTest.cpp:69 +} \ No newline at end of file ---------------- Please fix the `No newline at end of file`. Repository: rL LLVM https://reviews.llvm.org/D34440 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
