bob.wilson added a comment.

The proposed error message does not provide any information about why the 
version is invalid. That could be confusing. Your comment in the code is more 
clear: "iOS 10 is the maximum deployment target for 32-bit targets". Can you 
say something like that in the error message?

In the case where the version is inferred from the SDK, you're resetting 
Major=10 but leaving Minor and Micro unchanged. That seems wrong. Those should 
be set to the most recent release of iOS 10. Perhaps you could set those to big 
numbers, e.g., 99, so that they are sure to include any future iOS 10 releases.


https://reviews.llvm.org/D34529



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to