vbvictor wrote:

> > LGTM But there are still some violations left?
> 
> Yes, two more. Unfortunately, they require some refactoring as 
> `llvm::yaml::IO` API uses C-strings only.

We can use a `// NOLINT(bugprone-suspicious-stringview-data-usage)` or `// 
NOLINTNEXTLINE(bugprone-suspicious-stringview-data-usage)` to suppress it for 
now, and enable this check in config.
Later `IO` class could be refactored.



https://github.com/llvm/llvm-project/pull/158480
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to