arphaman added a comment. Thanks for the fix! The implementation looks correct. A couple of misc comments:
- Please move the test to `test/Index` (Since it uses `c-index-test`). - In the future please upload patches with full context (`git diff -U9999`). ================ Comment at: lib/Sema/SemaDeclCXX.cpp:3771 + TInfo = Context.CreateTypeSourceInfo(BaseType); + DependentNameTypeLoc TL = TInfo->getTypeLoc().castAs<DependentNameTypeLoc>(); + if (!TL.isNull()) { ---------------- This line violates the 80 columns. Please use clang-format! https://reviews.llvm.org/D32439 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits