johannes added inline comments.
================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:171
+
+std::string TreeRoot::label(NodeId Id) const {
+ const Node &N = getNode(Id);
----------------
arphaman wrote:
> I believe that this method that you call `label` actually represents the
> `value` attribute that's described in the paper for the gumtree algorithm. Is
> that right? If so, then this method name should be updated to reflect that.
Yes, good catch. Strangely, the gumtree implementation uses `label`. I think we
should use `type` for node kinds and `value` for their actual value, in order
to avoid confusion about what a label is.
https://reviews.llvm.org/D34329
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
