jansvoboda11 wrote:

This seems like a problem that's not specific to `clang-scan-deps` - most 
(all?) Clang-based tools will output mixed separators if that's the command 
line spelling. I would prefer improving LIT and FileCheck to inject and match 
the platform preferred separator. I don't want to block you on that, so I'm 
okay with the approach in this PR. Can we just make it so that the entire 
output-emitting code of `clang-scan-deps` uses a single instance of 
`SmallString`, so that we don't keep allocating on the stack over and over 
again unnecessarily? I'd also suggest using some common buffer size instead of 
`261` - that's most likely a unique instantiation in this TU.

https://github.com/llvm/llvm-project/pull/155908
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to