carlosgalvezp wrote: > we shouldn't discourage people from improving the codebase
These are orthogonal issues. People are always welcome to improve the codebase, but small PRs are essential for a healthy codebase. And it will actually be **less* work for the author, because the patches will be able to merge sooner than a mega-patch (quicker review, less conflicts, less CI checks). Also, issues like the one that was brought up in this patch are less likely to be found on a mega-patch. Last, such a mega-patch generates a lot of review noise for everyone involved since every interaction generates a notification/email for everyone, even if it's unrelated to their subproject. Doing this in N patches is trivial and I don't think it's requiring much of the author. https://github.com/llvm/llvm-project/pull/156270 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
