================ @@ -0,0 +1,127 @@ +//===----------------------------------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "DerivedMethodShadowingBaseMethodCheck.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/ASTMatchers/ASTMatchers.h" +#include <stack> + +using namespace clang::ast_matchers; + +namespace clang::tidy::bugprone { + +namespace { + +bool sameBasicType(const ParmVarDecl *Lhs, const ParmVarDecl *Rhs) { + if (Lhs && Rhs) { + return Lhs->getType() + .getCanonicalType() + .getNonReferenceType() + .getUnqualifiedType() == Rhs->getType() + .getCanonicalType() + .getNonReferenceType() + .getUnqualifiedType(); + } + return false; +} + +bool namesCollide(const CXXMethodDecl &Lhs, const CXXMethodDecl &Rhs) { + if (Lhs.getNameAsString() != Rhs.getNameAsString()) + return false; + if (Lhs.isConst() != Rhs.isConst()) + return false; + if (Lhs.getNumParams() != Rhs.getNumParams()) + return false; + for (unsigned int It = 0; It < Lhs.getNumParams(); ++It) + if (!sameBasicType(Lhs.getParamDecl(It), Rhs.getParamDecl(It))) + return false; + return true; +} + +AST_MATCHER(CXXMethodDecl, nameCollidesWithMethodInBase) { + const CXXRecordDecl *DerivedClass = Node.getParent(); + for (const auto &Base : DerivedClass->bases()) { + std::stack<const CXXBaseSpecifier *> Stack; ---------------- localspook wrote:
I think this is a good place for a `SmallVector` (it provides a small buffer optimization). Something like `SmallVector<const CXXBaseSpecifier *, 8>` should allow us to get away with no allocations for the vast majority of classes. https://github.com/llvm/llvm-project/pull/154746 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
