voskresensky.vladimir added a comment.

Hello Argyrios,
This is a good addition to simplify reuse of preprocessor in IDEs. Thanks for 
doing this.

From our experience of integrating clang PP into NetBeans, the following change 
gives more flexibility:

- introduce method in PPCallbacks and consult it what is the preferred value 
for undefined symbol

It will be similar to approach used for unresolved includes and FileNotFound 
method.
It also gives dynamic behavior for clients:  client might still prefer to keep 
skipping some blocks like unix, mac, win, solaris, LP64, cplusplus, ...

Thanks,
Vladimir.


https://reviews.llvm.org/D34263



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to