Keenuts wrote: > My only concern is that the parser does not allow digits in the middle of the > semantic name. I believe that is possible for user semantics. It works for > DXC. Otherwise LGTM.
Thank you all! reworked the semantic parsing to allow digits in the middle of the identifier. This simplified a bit the parsing. Extended testing to cover those. Also addressed all other PR comments. https://github.com/llvm/llvm-project/pull/152537 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
