aaron.ballman added inline comments.
================
Comment at: clang-tidy/readability/RedundantKeywordCheck.cpp:22
+template <class T>
+static bool startsWith(const T &Node, StringRef Value) {
+ Token Result;
----------------
Why do you need to do a textual search that the first token in the declaration
is extern or inline? That seems like it would fail on common cases that you
would expect to catch:
```
#define FOO_EXTERN extern
FOO_EXTERN void blah();
```
================
Comment at: test/clang-tidy/readability-redundant-keyword.cpp:22
+
+extern "C" void ok();
+
----------------
Why is this okay, but the following is not?
```
extern "C++" void ok2();
```
Repository:
rL LLVM
https://reviews.llvm.org/D33841
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
