[clang] [NFC][Diagnostics] Prevent incorrect clang-format reformatting in some headers related to Clang diagnostics (PR #154628)

[Dan Liew via cfe-commits]

================
@@ -14,6 +14,7 @@
 #ifndef LLVM_CLANG_BASIC_ALLDIAGNOSTICS_H
 #define LLVM_CLANG_BASIC_ALLDIAGNOSTICS_H
 
+// clang-format off
----------------
delcypher wrote:

@Sirraide Is it both files you were thinking of reformatting? I'm happy to 
reformat `AllDiagnostics.h` but `clang-format` makes a real mess of 
`DiagnosticIDs.h`. The declaration of the enum is very deliberately formatted 
to be readable and isn't as readable after formatting which looks like:

```[lang=c++]
    enum {
      DIAG_START_COMMON = 0, 
      DIAG_START_DRIVER =
          DIAG_START_COMMON + static_cast<int>(DIAG_SIZE_COMMON),
      DIAG_START_FRONTEND =
          DIAG_START_DRIVER + static_cast<int>(DIAG_SIZE_DRIVER),
      DIAG_START_SERIALIZATION =
          DIAG_START_FRONTEND + static_cast<int>(DIAG_SIZE_FRONTEND),
      DIAG_START_LEX =
          DIAG_START_SERIALIZATION + static_cast<int>(DIAG_SIZE_SERIALIZATION),
      DIAG_START_PARSE = DIAG_START_LEX + static_cast<int>(DIAG_SIZE_LEX),
      DIAG_START_AST = DIAG_START_PARSE + static_cast<int>(DIAG_SIZE_PARSE),
      DIAG_START_COMMENT = DIAG_START_AST + static_cast<int>(DIAG_SIZE_AST),
      DIAG_START_CROSSTU =
          DIAG_START_COMMENT + static_cast<int>(DIAG_SIZE_COMMENT),
      DIAG_START_SEMA =
          DIAG_START_CROSSTU + static_cast<int>(DIAG_SIZE_CROSSTU),
      DIAG_START_ANALYSIS = DIAG_START_SEMA + static_cast<int>(DIAG_SIZE_SEMA),
      DIAG_START_REFACTORING =
          DIAG_START_ANALYSIS + static_cast<int>(DIAG_SIZE_ANALYSIS),
      DIAG_START_INSTALLAPI =
          DIAG_START_REFACTORING + static_cast<int>(DIAG_SIZE_REFACTORING),
      DIAG_UPPER_LIMIT =
          DIAG_START_INSTALLAPI + static_cast<int>(DIAG_SIZE_INSTALLAPI)
    };
```

whereas before it was:

```
    enum {
      DIAG_START_COMMON        =                          0,
      DIAG_START_DRIVER        = DIAG_START_COMMON        + 
static_cast<int>(DIAG_SIZE_COMMON),
      DIAG_START_FRONTEND      = DIAG_START_DRIVER        + 
static_cast<int>(DIAG_SIZE_DRIVER),
      DIAG_START_SERIALIZATION = DIAG_START_FRONTEND      + 
static_cast<int>(DIAG_SIZE_FRONTEND),
      DIAG_START_LEX           = DIAG_START_SERIALIZATION + 
static_cast<int>(DIAG_SIZE_SERIALIZATION),
      DIAG_START_PARSE         = DIAG_START_LEX           + 
static_cast<int>(DIAG_SIZE_LEX),
      DIAG_START_AST           = DIAG_START_PARSE         + 
static_cast<int>(DIAG_SIZE_PARSE),
      DIAG_START_COMMENT       = DIAG_START_AST           + 
static_cast<int>(DIAG_SIZE_AST),
      DIAG_START_CROSSTU       = DIAG_START_COMMENT       + 
static_cast<int>(DIAG_SIZE_COMMENT),
      DIAG_START_SEMA          = DIAG_START_CROSSTU       + 
static_cast<int>(DIAG_SIZE_CROSSTU),
      DIAG_START_ANALYSIS      = DIAG_START_SEMA          + 
static_cast<int>(DIAG_SIZE_SEMA),
      DIAG_START_REFACTORING   = DIAG_START_ANALYSIS      + 
static_cast<int>(DIAG_SIZE_ANALYSIS),
      DIAG_START_INSTALLAPI    = DIAG_START_REFACTORING   + 
static_cast<int>(DIAG_SIZE_REFACTORING),
      DIAG_UPPER_LIMIT         = DIAG_START_INSTALLAPI    + 
static_cast<int>(DIAG_SIZE_INSTALLAPI)
    };
```

https://github.com/llvm/llvm-project/pull/154628
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits