MythreyaK wrote:

Thanks for the review! 

I have 2 remaining questions, 
1. With this PR, these 2 show up as overloads, though not sure if they should 
be considered overloads. It's convenient, but wanted to double-check. 
    ```cpp
    void foo2(int a);
    void foo2(this const S& self, float a); // shows up as overload of foo2
    ```
2. There seems to be an issue with the lit tests, [described 
here](https://github.com/llvm/llvm-project/pull/154041#discussion_r2281844547). 
Is this a problem? 

https://github.com/llvm/llvm-project/pull/154041
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to