================ @@ -1813,6 +1813,7 @@ void ScalarExprEmitter::EmitBinOpCheck( SanitizerHandler Check; SmallVector<llvm::Constant *, 4> StaticData; SmallVector<llvm::Value *, 2> DynamicData; + std::unique_ptr<RuntimeTrapDiagnosticBuilder> RTDB = nullptr; ---------------- Sirraide wrote:
Actually, this is in a function—I thought it was at class scope for some reason; in that case it makes sense for this declaration to be here, but I think it should be fine to just create the diagnostic builder in any case (assuming we don’t heap-allocate them; see my other comments). https://github.com/llvm/llvm-project/pull/154618 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
