github-actions[bot] wrote: <!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning: <details> <summary> You can test this locally with the following command: </summary> ``````````bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/clang/AST/Type.h clang/include/clang/AST/TypeLoc.h clang/include/clang/Sema/Sema.h clang/include/clang/Sema/SemaInternal.h clang/lib/AST/ASTContext.cpp clang/lib/AST/ASTImporter.cpp clang/lib/AST/ASTStructuralEquivalence.cpp clang/lib/AST/DeclTemplate.cpp clang/lib/AST/ItaniumMangle.cpp clang/lib/AST/MicrosoftMangle.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp clang/lib/Parse/ParseTemplate.cpp clang/lib/Sema/SemaConcept.cpp clang/lib/Sema/SemaDeclCXX.cpp clang/lib/Sema/SemaTemplate.cpp clang/lib/Sema/SemaTemplateDeduction.cpp clang/lib/Sema/SemaTemplateInstantiate.cpp clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang/lib/Sema/SemaTemplateVariadic.cpp clang/lib/Sema/TreeTransform.h clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTWriter.cpp clang/test/Import/builtin-template/Inputs/S.cpp clang/test/Import/builtin-template/test.cpp clang/test/SemaCXX/pr100095.cpp clang/tools/libclang/CIndex.cpp `````````` </details> <details> <summary> View the diff from clang-format here. </summary> ``````````diff diff --git a/clang/include/clang/AST/ASTContext.h b/clang/include/clang/AST/ASTContext.h index 7c2566a09..98be96238 100644 --- a/clang/include/clang/AST/ASTContext.h +++ b/clang/include/clang/AST/ASTContext.h @@ -229,7 +229,7 @@ class ASTContext : public RefCountedBase<ASTContext> { mutable llvm::FoldingSet<SubstTemplateTypeParmType> SubstTemplateTypeParmTypes; mutable llvm::FoldingSet<SubstTemplateTypeParmPackType> - SubstTemplateTypeParmPackTypes; + SubstTemplateTypeParmPackTypes; mutable llvm::ContextualFoldingSet<TemplateSpecializationType, ASTContext&> TemplateSpecializationTypes; mutable llvm::FoldingSet<ParenType> ParenTypes{GeneralTypesLog2InitSize}; diff --git a/clang/include/clang/AST/RecursiveASTVisitor.h b/clang/include/clang/AST/RecursiveASTVisitor.h index 248b89200..de0d423da 100644 --- a/clang/include/clang/AST/RecursiveASTVisitor.h +++ b/clang/include/clang/AST/RecursiveASTVisitor.h @@ -1138,9 +1138,8 @@ DEF_TRAVERSE_TYPE(TemplateTypeParmType, {}) DEF_TRAVERSE_TYPE(SubstTemplateTypeParmType, { TRY_TO(TraverseType(T->getReplacementType())); }) -DEF_TRAVERSE_TYPE(SubstTemplateTypeParmPackType, { - TRY_TO(TraverseTemplateArgument(T->getArgumentPack())); -}) +DEF_TRAVERSE_TYPE(SubstTemplateTypeParmPackType, + { TRY_TO(TraverseTemplateArgument(T->getArgumentPack())); }) DEF_TRAVERSE_TYPE(AttributedType, { TRY_TO(TraverseType(T->getModifiedType())); }) diff --git a/clang/include/clang/AST/TypeLoc.h b/clang/include/clang/AST/TypeLoc.h index 6389bdea6..5f9d6b63e 100644 --- a/clang/include/clang/AST/TypeLoc.h +++ b/clang/include/clang/AST/TypeLoc.h @@ -989,12 +989,11 @@ class SubstTemplateTypeParmTypeLoc : SubstTemplateTypeParmType> { }; - /// Wrapper for substituted template type parameters. -class SubstTemplateTypeParmPackTypeLoc : - public InheritingConcreteTypeLoc<TypeSpecTypeLoc, - SubstTemplateTypeParmPackTypeLoc, - SubstTemplateTypeParmPackType> { -}; +/// Wrapper for substituted template type parameters. +class SubstTemplateTypeParmPackTypeLoc + : public InheritingConcreteTypeLoc<TypeSpecTypeLoc, + SubstTemplateTypeParmPackTypeLoc, + SubstTemplateTypeParmPackType> {}; struct AttributedLocInfo { const Attr *TypeAttr; diff --git a/clang/lib/Sema/SemaTemplateDeduction.cpp b/clang/lib/Sema/SemaTemplateDeduction.cpp index 477f8c754..6f434ab95 100644 --- a/clang/lib/Sema/SemaTemplateDeduction.cpp +++ b/clang/lib/Sema/SemaTemplateDeduction.cpp @@ -6967,8 +6967,8 @@ MarkUsedTemplateParameters(ASTContext &Ctx, QualType T, = cast<SubstTemplateTypeParmPackType>(T); if (Subst->getReplacedParameter()->getDepth() == Depth) Used[Subst->getIndex()] = true; - MarkUsedTemplateParameters(Ctx, Subst->getArgumentPack(), - OnlyDeduced, Depth, Used); + MarkUsedTemplateParameters(Ctx, Subst->getArgumentPack(), OnlyDeduced, + Depth, Used); break; } diff --git a/clang/lib/Sema/SemaTemplateInstantiate.cpp b/clang/lib/Sema/SemaTemplateInstantiate.cpp index 5e8dfd19f..c844dd3fe 100644 --- a/clang/lib/Sema/SemaTemplateInstantiate.cpp +++ b/clang/lib/Sema/SemaTemplateInstantiate.cpp @@ -3473,12 +3473,9 @@ Sema::SubstBaseSpecifiers(CXXRecordDecl *Instantiation, bool ShouldExpand = false; bool RetainExpansion = false; UnsignedOrNone NumExpansions = std::nullopt; - if (CheckParameterPacksForExpansion(Base.getEllipsisLoc(), - Base.getSourceRange(), - Unexpanded, - TemplateArgs, ShouldExpand, - RetainExpansion, - NumExpansions)) { + if (CheckParameterPacksForExpansion( + Base.getEllipsisLoc(), Base.getSourceRange(), Unexpanded, + TemplateArgs, ShouldExpand, RetainExpansion, NumExpansions)) { Invalid = true; continue; } @@ -3488,22 +3485,18 @@ Sema::SubstBaseSpecifiers(CXXRecordDecl *Instantiation, for (unsigned I = 0; I != *NumExpansions; ++I) { Sema::ArgPackSubstIndexRAII SubstIndex(*this, I); - TypeSourceInfo *BaseTypeLoc = SubstType(Base.getTypeSourceInfo(), - TemplateArgs, - Base.getSourceRange().getBegin(), - DeclarationName()); + TypeSourceInfo *BaseTypeLoc = + SubstType(Base.getTypeSourceInfo(), TemplateArgs, + Base.getSourceRange().getBegin(), DeclarationName()); if (!BaseTypeLoc) { Invalid = true; continue; } - if (CXXBaseSpecifier *InstantiatedBase - = CheckBaseSpecifier(Instantiation, - Base.getSourceRange(), - Base.isVirtual(), - Base.getAccessSpecifierAsWritten(), - BaseTypeLoc, - SourceLocation())) + if (CXXBaseSpecifier *InstantiatedBase = CheckBaseSpecifier( + Instantiation, Base.getSourceRange(), Base.isVirtual(), + Base.getAccessSpecifierAsWritten(), BaseTypeLoc, + SourceLocation())) InstantiatedBases.push_back(InstantiatedBase); else Invalid = true; @@ -3515,10 +3508,9 @@ Sema::SubstBaseSpecifiers(CXXRecordDecl *Instantiation, // The resulting base specifier will (still) be a pack expansion. EllipsisLoc = Base.getEllipsisLoc(); Sema::ArgPackSubstIndexRAII SubstIndex(*this, std::nullopt); - BaseTypeLoc = SubstType(Base.getTypeSourceInfo(), - TemplateArgs, - Base.getSourceRange().getBegin(), - DeclarationName()); + BaseTypeLoc = + SubstType(Base.getTypeSourceInfo(), TemplateArgs, + Base.getSourceRange().getBegin(), DeclarationName()); } else { BaseTypeLoc = SubstType(Base.getTypeSourceInfo(), TemplateArgs, diff --git a/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp b/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp index 6b423ce06..d6b670c06 100644 --- a/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp +++ b/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp @@ -3464,9 +3464,9 @@ Decl *TemplateDeclInstantiator::VisitTemplateTypeParmDecl( cast<CXXFoldExpr>(TC->getImmediatelyDeclaredConstraint()) ->getEllipsisLoc(), SourceRange(TC->getConceptNameLoc(), - TC->hasExplicitTemplateArgs() ? - TC->getTemplateArgsAsWritten()->getRAngleLoc() : - TC->getConceptNameInfo().getEndLoc()), + TC->hasExplicitTemplateArgs() + ? TC->getTemplateArgsAsWritten()->getRAngleLoc() + : TC->getConceptNameInfo().getEndLoc()), Unexpanded, TemplateArgs, Expand, RetainExpansion, NumExpanded)) return nullptr; } @@ -3555,12 +3555,9 @@ Decl *TemplateDeclInstantiator::VisitNonTypeTemplateParmDecl( UnsignedOrNone OrigNumExpansions = Expansion.getTypePtr()->getNumExpansions(); UnsignedOrNone NumExpansions = OrigNumExpansions; - if (SemaRef.CheckParameterPacksForExpansion(Expansion.getEllipsisLoc(), - Pattern.getSourceRange(), - Unexpanded, - TemplateArgs, - Expand, RetainExpansion, - NumExpansions)) + if (SemaRef.CheckParameterPacksForExpansion( + Expansion.getEllipsisLoc(), Pattern.getSourceRange(), Unexpanded, + TemplateArgs, Expand, RetainExpansion, NumExpansions)) return nullptr; if (Expand) { @@ -3726,12 +3723,9 @@ TemplateDeclInstantiator::VisitTemplateTemplateParmDecl( bool Expand = true; bool RetainExpansion = false; UnsignedOrNone NumExpansions = std::nullopt; - if (SemaRef.CheckParameterPacksForExpansion(D->getLocation(), - TempParams->getSourceRange(), - Unexpanded, - TemplateArgs, - Expand, RetainExpansion, - NumExpansions)) + if (SemaRef.CheckParameterPacksForExpansion( + D->getLocation(), TempParams->getSourceRange(), Unexpanded, + TemplateArgs, Expand, RetainExpansion, NumExpansions)) return nullptr; if (Expand) { @@ -4003,7 +3997,7 @@ Decl *TemplateDeclInstantiator::instantiateUnresolvedUsingDecl( bool RetainExpansion = false; UnsignedOrNone NumExpansions = std::nullopt; if (SemaRef.CheckParameterPacksForExpansion( - D->getEllipsisLoc(), D->getSourceRange(), Unexpanded, TemplateArgs, + D->getEllipsisLoc(), D->getSourceRange(), Unexpanded, TemplateArgs, Expand, RetainExpansion, NumExpansions)) return nullptr; @@ -6401,12 +6395,9 @@ Sema::InstantiateMemInitializers(CXXConstructorDecl *New, bool ShouldExpand = false; bool RetainExpansion = false; UnsignedOrNone NumExpansions = std::nullopt; - if (CheckParameterPacksForExpansion(Init->getEllipsisLoc(), - BaseTL.getSourceRange(), - Unexpanded, - TemplateArgs, ShouldExpand, - RetainExpansion, - NumExpansions)) { + if (CheckParameterPacksForExpansion( + Init->getEllipsisLoc(), BaseTL.getSourceRange(), Unexpanded, + TemplateArgs, ShouldExpand, RetainExpansion, NumExpansions)) { AnyErrors = true; New->setInvalidDecl(); continue; diff --git a/clang/lib/Sema/SemaTemplateVariadic.cpp b/clang/lib/Sema/SemaTemplateVariadic.cpp index 377f2ed35..a48e5c7ae 100644 --- a/clang/lib/Sema/SemaTemplateVariadic.cpp +++ b/clang/lib/Sema/SemaTemplateVariadic.cpp @@ -731,7 +731,7 @@ QualType Sema::CheckPackExpansion(QualType Pattern, SourceRange PatternRange, if (!Pattern->containsUnexpandedParameterPack() && !Pattern->getContainedDeducedType()) { Diag(EllipsisLoc, diag::err_pack_expansion_without_parameter_packs) - << PatternRange; + << PatternRange; return QualType(); } diff --git a/clang/lib/Sema/TreeTransform.h b/clang/lib/Sema/TreeTransform.h index 13cc6f1b2..e849371a5 100644 --- a/clang/lib/Sema/TreeTransform.h +++ b/clang/lib/Sema/TreeTransform.h @@ -4461,11 +4461,9 @@ bool TreeTransform<Derived>::TransformExprs(Expr *const *Inputs, bool RetainExpansion = false; UnsignedOrNone OrigNumExpansions = Expansion->getNumExpansions(); UnsignedOrNone NumExpansions = OrigNumExpansions; - if (getDerived().TryExpandParameterPacks(Expansion->getEllipsisLoc(), - Pattern->getSourceRange(), - Unexpanded, - Expand, RetainExpansion, - NumExpansions)) + if (getDerived().TryExpandParameterPacks( + Expansion->getEllipsisLoc(), Pattern->getSourceRange(), + Unexpanded, Expand, RetainExpansion, NumExpansions)) return true; if (!Expand) { @@ -5085,9 +5083,9 @@ bool TreeTransform<Derived>::TransformTemplateArguments( // the pattern. SourceLocation Ellipsis; UnsignedOrNone OrigNumExpansions = std::nullopt; - TemplateArgumentLoc Pattern - = getSema().getTemplateArgumentPackExpansionPattern( - In, Ellipsis, OrigNumExpansions); + TemplateArgumentLoc Pattern = + getSema().getTemplateArgumentPackExpansionPattern(In, Ellipsis, + OrigNumExpansions); SmallVector<UnexpandedParameterPack, 2> Unexpanded; getSema().collectUnexpandedParameterPacks(Pattern, Unexpanded); @@ -5098,12 +5096,9 @@ bool TreeTransform<Derived>::TransformTemplateArguments( bool Expand = true; bool RetainExpansion = false; UnsignedOrNone NumExpansions = OrigNumExpansions; - if (getDerived().TryExpandParameterPacks(Ellipsis, - Pattern.getSourceRange(), - Unexpanded, - Expand, - RetainExpansion, - NumExpansions)) + if (getDerived().TryExpandParameterPacks( + Ellipsis, Pattern.getSourceRange(), Unexpanded, Expand, + RetainExpansion, NumExpansions)) return true; if (!Expand) { @@ -5150,8 +5145,8 @@ bool TreeTransform<Derived>::TransformTemplateArguments( if (getDerived().TransformTemplateArgument(Pattern, Out, Uneval)) return true; - Out = getDerived().RebuildPackExpansion(Out, Ellipsis, - OrigNumExpansions); + Out = + getDerived().RebuildPackExpansion(Out, Ellipsis, OrigNumExpansions); if (Out.getArgument().isNull()) return true; @@ -6182,12 +6177,9 @@ bool TreeTransform<Derived>::TransformFunctionTypeParams( if (Unexpanded.size() > 0) { OrigNumExpansions = ExpansionTL.getTypePtr()->getNumExpansions(); NumExpansions = OrigNumExpansions; - if (getDerived().TryExpandParameterPacks(ExpansionTL.getEllipsisLoc(), - Pattern.getSourceRange(), - Unexpanded, - ShouldExpand, - RetainExpansion, - NumExpansions)) { + if (getDerived().TryExpandParameterPacks( + ExpansionTL.getEllipsisLoc(), Pattern.getSourceRange(), + Unexpanded, ShouldExpand, RetainExpansion, NumExpansions)) { return true; } } else { @@ -6293,10 +6285,8 @@ bool TreeTransform<Derived>::TransformFunctionTypeParams( // Determine whether we should expand the parameter packs. bool ShouldExpand = false; bool RetainExpansion = false; - if (getDerived().TryExpandParameterPacks(Loc, SourceRange(), - Unexpanded, - ShouldExpand, - RetainExpansion, + if (getDerived().TryExpandParameterPacks(Loc, SourceRange(), Unexpanded, + ShouldExpand, RetainExpansion, NumExpansions)) { return true; } @@ -6593,9 +6583,9 @@ bool TreeTransform<Derived>::TransformExceptionSpec( UnsignedOrNone NumExpansions = PackExpansion->getNumExpansions(); // FIXME: Track the location of the ellipsis (and track source location // information for the types in the exception specification in general). - if (getDerived().TryExpandParameterPacks( - Loc, SourceRange(), Unexpanded, Expand, - RetainExpansion, NumExpansions)) + if (getDerived().TryExpandParameterPacks(Loc, SourceRange(), Unexpanded, + Expand, RetainExpansion, + NumExpansions)) return true; if (!Expand) { @@ -7129,7 +7119,6 @@ QualType TreeTransform<Derived>::TransformSubstTemplateTypeParmType( = TLB.push<SubstTemplateTypeParmTypeLoc>(Result); NewTL.setNameLoc(TL.getNameLoc()); return Result; - } template<typename Derived> @@ -7857,8 +7846,8 @@ TreeTransform<Derived>::TransformObjCObjectType(TypeLocBuilder &TLB, bool RetainExpansion = false; UnsignedOrNone NumExpansions = PackExpansion->getNumExpansions(); if (getDerived().TryExpandParameterPacks( - PackExpansionLoc.getEllipsisLoc(), PatternLoc.getSourceRange(), - Unexpanded, Expand, RetainExpansion, NumExpansions)) + PackExpansionLoc.getEllipsisLoc(), PatternLoc.getSourceRange(), + Unexpanded, Expand, RetainExpansion, NumExpansions)) return QualType(); if (!Expand) { @@ -14841,11 +14830,9 @@ TreeTransform<Derived>::TransformTypeTraitExpr(TypeTraitExpr *E) { UnsignedOrNone OrigNumExpansions = ExpansionTL.getTypePtr()->getNumExpansions(); UnsignedOrNone NumExpansions = OrigNumExpansions; - if (getDerived().TryExpandParameterPacks(ExpansionTL.getEllipsisLoc(), - PatternTL.getSourceRange(), - Unexpanded, - Expand, RetainExpansion, - NumExpansions)) + if (getDerived().TryExpandParameterPacks( + ExpansionTL.getEllipsisLoc(), PatternTL.getSourceRange(), + Unexpanded, Expand, RetainExpansion, NumExpansions)) return ExprError(); if (!Expand) { @@ -15419,9 +15406,8 @@ TreeTransform<Derived>::TransformLambdaExpr(LambdaExpr *E) { ExpansionTL.getTypePtr()->getNumExpansions(); UnsignedOrNone NumExpansions = OrigNumExpansions; if (getDerived().TryExpandParameterPacks( - ExpansionTL.getEllipsisLoc(), - OldVD->getInit()->getSourceRange(), Unexpanded, Expand, - RetainExpansion, NumExpansions)) + ExpansionTL.getEllipsisLoc(), OldVD->getInit()->getSourceRange(), + Unexpanded, Expand, RetainExpansion, NumExpansions)) return ExprError(); assert(!RetainExpansion && "Should not need to retain expansion after a " "capture since it cannot be extended"); @@ -15580,11 +15566,9 @@ TreeTransform<Derived>::TransformLambdaExpr(LambdaExpr *E) { bool ShouldExpand = false; bool RetainExpansion = false; UnsignedOrNone NumExpansions = std::nullopt; - if (getDerived().TryExpandParameterPacks(C->getEllipsisLoc(), - C->getLocation(), - Unexpanded, - ShouldExpand, RetainExpansion, - NumExpansions)) { + if (getDerived().TryExpandParameterPacks( + C->getEllipsisLoc(), C->getLocation(), Unexpanded, ShouldExpand, + RetainExpansion, NumExpansions)) { Invalid = true; continue; } @@ -16098,10 +16082,9 @@ TreeTransform<Derived>::TransformSizeOfPackExpr(SizeOfPackExpr *E) { bool ShouldExpand = false; bool RetainExpansion = false; UnsignedOrNone NumExpansions = std::nullopt; - if (getDerived().TryExpandParameterPacks(E->getOperatorLoc(), E->getPackLoc(), - Unexpanded, - ShouldExpand, RetainExpansion, - NumExpansions)) + if (getDerived().TryExpandParameterPacks( + E->getOperatorLoc(), E->getPackLoc(), Unexpanded, ShouldExpand, + RetainExpansion, NumExpansions)) return ExprError(); // If we need to expand the pack, build a template argument from it and @@ -16324,11 +16307,9 @@ TreeTransform<Derived>::TransformCXXFoldExpr(CXXFoldExpr *E) { bool RetainExpansion = false; UnsignedOrNone OrigNumExpansions = E->getNumExpansions(), NumExpansions = OrigNumExpansions; - if (getDerived().TryExpandParameterPacks(E->getEllipsisLoc(), - Pattern->getSourceRange(), - Unexpanded, - Expand, RetainExpansion, - NumExpansions)) + if (getDerived().TryExpandParameterPacks( + E->getEllipsisLoc(), Pattern->getSourceRange(), Unexpanded, Expand, + RetainExpansion, NumExpansions)) return true; if (!Expand) { `````````` </details> https://github.com/llvm/llvm-project/pull/154606 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits