ilovepi wrote:

FWIW, we're seeing this in Fuchsia too.

Bot: 
https://ci.chromium.org/ui/p/fuchsia/builders/global.ci/clang_toolchain.ci.core.x64-debug-tot-build_only/b8706156533673690033/overview

Logs: 
https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8706156533673690033/+/u/build/ninja/stdout

The logs show that this is mostly in third party code, but that also means we 
may not be able to easily get it changed, and will have to suppress these on a 
case-by-case basis.

In particular the tcpdump cases also seem benign to me:
https://cs.opensource.google/fuchsia/fuchsia/+/main:third_party/tcpdump/src/print-802_11.c;l=835

> Another idea would be to revert these changes and instead make a clang-tidy 
> check that's more aggressive.

I think that would be our preference. 

https://github.com/llvm/llvm-project/pull/154018
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to