=?utf-8?q?Balázs_Kéri?= <balazs.k...@ericsson.com>, =?utf-8?q?Balázs_Kéri?= <balazs.k...@ericsson.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/153...@github.com>
https://github.com/PiotrZSL requested changes to this pull request. Consider changing name, to: `bugprone-suspicious-cast-to-struct-pointer`. When I first read name of check I immediately had this construction in mind: ``` struct A { ... }; struct B : A { ... }; const A a; const B& b = (B)a; ``` Current name is too generic. - Consider extending this to C++. - Consider ignoring char/u8* types by default. Consider supporting typedefs (you may need to resolve them 1 by 1). - Consider ignoring system headers. - Consider using TK_IgnoreUnlessSpelledInSource explicitly. https://github.com/llvm/llvm-project/pull/153428 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
