Sirraide wrote: > I prefer keeping my PRs atomic. All of my changes in that PR are necessary > towards the primary goal of that PR, whereas this change wouldn't be. If I > allowed myself to make refactors whenever I'm working on a feature it would > introduce quite a bit of noise, which seems like a bad habit to have.
I mean, altenratively we could just wait until the other pr is merged and then merge this one afterwards; I just don’t like the idea of making a non-obvious change if there are no tests at all for it (unless we already have test that I missed but I couldn’t find any). https://github.com/llvm/llvm-project/pull/152865 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
