tejohnson added a comment.

Make sure you add cfe-commits to the mailing list for clang changes (and 
llvm-commits for llvm changes, I accidentally added that one first and then 
fixed it), since all patches should go to the full mailing list.

This fix looks correct to me. Please add a test case though. Perhaps there 
should be an error if the value is something other than "thin" or "lto"? E.g. 
see the error that will get emitted if the value is not one of those in 
clang/lib/Driver/Driver.cpp.


https://reviews.llvm.org/D34055



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to