https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/152259
stringVal is already of char *.
>From 633a2261fac10c1f271905603955c9ef14d81798 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <k...@google.com>
Date: Tue, 5 Aug 2025 08:03:57 -0700
Subject: [PATCH] [libclang] Remove unnecessary casts (NFC)
stringVal is already of char *.
---
clang/tools/libclang/CIndex.cpp | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/clang/tools/libclang/CIndex.cpp b/clang/tools/libclang/CIndex.cpp
index 95cda674a5895..8b3d70b25866f 100644
--- a/clang/tools/libclang/CIndex.cpp
+++ b/clang/tools/libclang/CIndex.cpp
@@ -4720,8 +4720,7 @@ static const ExprEvalResult *evaluateExpr(Expr *expr,
CXCursor C) {
std::string strRef(StrE->getString().str());
result->EvalData.stringVal = new char[strRef.size() + 1];
- strncpy((char *)result->EvalData.stringVal, strRef.c_str(),
- strRef.size());
+ strncpy(result->EvalData.stringVal, strRef.c_str(), strRef.size());
result->EvalData.stringVal[strRef.size()] = '\0';
return result.release();
}
@@ -4741,7 +4740,7 @@ static const ExprEvalResult *evaluateExpr(Expr *expr,
CXCursor C) {
std::string strRef(StrE->getString().str());
result->EvalData.stringVal = new char[strRef.size() + 1];
- strncpy((char *)result->EvalData.stringVal, strRef.c_str(), strRef.size());
+ strncpy(result->EvalData.stringVal, strRef.c_str(), strRef.size());
result->EvalData.stringVal[strRef.size()] = '\0';
return result.release();
}
@@ -4760,7 +4759,7 @@ static const ExprEvalResult *evaluateExpr(Expr *expr,
CXCursor C) {
result->EvalType = CXEval_CFStr;
result->EvalData.stringVal = new char[strLiteral.size() + 1];
- strncpy((char *)result->EvalData.stringVal, strLiteral.c_str(),
+ strncpy(result->EvalData.stringVal, strLiteral.c_str(),
strLiteral.size());
result->EvalData.stringVal[strLiteral.size()] = '\0';
return result.release();
@@ -4785,7 +4784,7 @@ static const ExprEvalResult *evaluateExpr(Expr *expr,
CXCursor C) {
std::string strLiteral(S->getString().str());
result->EvalType = CXEval_CFStr;
result->EvalData.stringVal = new char[strLiteral.size() + 1];
- strncpy((char *)result->EvalData.stringVal, strLiteral.c_str(),
+ strncpy(result->EvalData.stringVal, strLiteral.c_str(),
strLiteral.size());
result->EvalData.stringVal[strLiteral.size()] = '\0';
return result.release();
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
