ShashwathiNavada wrote:

> This looks basically right. But I'm not sure all the conditions for calling 
> it are correct. Is getDeclareMapperVarRef relevant? Does it matter what scope 
> we're inserting the variable into? (Can the variable be inserted in a 
> namespace? Can it be a local variable?)

@efriedma-quic  I've added the condition to check for local variables as you 
suggested. However, I believe getDeclareMapperVarRef() is relevant in this 
context, since I'm handling iterators declared in #pragma omp declare mapper. 
Let me know if you think any further changes are needed.

https://github.com/llvm/llvm-project/pull/141507
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to