alexfh added a comment. In https://reviews.llvm.org/D20693#775153, @alexfh wrote:
> In https://reviews.llvm.org/D20693#775014, @hintonda wrote: > > > - Only pass %2 parameter if %2 is included in format. > > > I thought, DiagnosticsBuilder handles placeholders in conditional parts > correctly. Did you find an evidence of the opposite? Can you add a test that > consistently fails? (without your latest change that is) https://reviews.llvm.org/D20693 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
