aaron.ballman added inline comments.

================
Comment at: include/clang/AST/Decl.h:901
+    /// member functions.
+    unsigned ImplicitParamKind : 3;
   };
----------------
ABataev wrote:
> aaron.ballman wrote:
> > It's a bit strange to me that the non-parameter declaration bits now have a 
> > field for implicit parameter information. Why here instead of 
> > `ParmVarDeclBits`?
> Actually, `ImplicitParamDecl` already uses some bits from the 
> `NonParmVarDeclBitfields`, at least it may be marked as `ARCPseudoStrong` for 
> ObjC. That's why I had to reuse `NonParmVarDeclBitfields` part.
Ew. That's nasty and we should probably fix that (not as part of this patch). 
Can you add a FIXME here?


https://reviews.llvm.org/D33735



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to