llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> We can pass a range to llvm::none_if. --- Full diff: https://github.com/llvm/llvm-project/pull/151801.diff 2 Files Affected: - (modified) clang-tools-extra/clang-tidy/bugprone/InvalidEnumDefaultInitializationCheck.cpp (+4-5) - (modified) clang-tools-extra/clang-tidy/bugprone/NonZeroEnumToBoolConversionCheck.cpp (+4-5) ``````````diff diff --git a/clang-tools-extra/clang-tidy/bugprone/InvalidEnumDefaultInitializationCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/InvalidEnumDefaultInitializationCheck.cpp index 33fcf45788277..f903e631e0be0 100644 --- a/clang-tools-extra/clang-tidy/bugprone/InvalidEnumDefaultInitializationCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/InvalidEnumDefaultInitializationCheck.cpp @@ -22,11 +22,10 @@ bool isCompleteAndHasNoZeroValue(const EnumDecl *D) { const EnumDecl *Definition = D->getDefinition(); return Definition && Definition->isComplete() && !Definition->enumerators().empty() && - std::none_of(Definition->enumerator_begin(), - Definition->enumerator_end(), - [](const EnumConstantDecl *Value) { - return Value->getInitVal().isZero(); - }); + llvm::none_of(Definition->enumerators(), + [](const EnumConstantDecl *Value) { + return Value->getInitVal().isZero(); + }); } AST_MATCHER(EnumDecl, isCompleteAndHasNoZeroValue) { diff --git a/clang-tools-extra/clang-tidy/bugprone/NonZeroEnumToBoolConversionCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/NonZeroEnumToBoolConversionCheck.cpp index e0323848870bd..e0b0df98d3409 100644 --- a/clang-tools-extra/clang-tidy/bugprone/NonZeroEnumToBoolConversionCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/NonZeroEnumToBoolConversionCheck.cpp @@ -22,11 +22,10 @@ namespace { AST_MATCHER(EnumDecl, isCompleteAndHasNoZeroValue) { const EnumDecl *Definition = Node.getDefinition(); return Definition && Node.isComplete() && - std::none_of(Definition->enumerator_begin(), - Definition->enumerator_end(), - [](const EnumConstantDecl *Value) { - return Value->getInitVal().isZero(); - }); + llvm::none_of(Definition->enumerators(), + [](const EnumConstantDecl *Value) { + return Value->getInitVal().isZero(); + }); } } // namespace `````````` </details> https://github.com/llvm/llvm-project/pull/151801 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
