================
@@ -124,6 +124,12 @@ New checks
   pointer and store it as class members without handle the copy and move
   constructors and the assignments.
 
+- New :doc:`bugprone-invalid-enum-default-initialization
----------------
NagyDonat wrote:

Unfortunately the github pull request UI gets confused when commits are rebased 
or amended on the branch that acts as the "source" of the PR. (IIRC inline 
comments will get lost, but there may be other problems as well.) For this 
reason I think it's prudent to use merge commits _during the lifetime of a 
github review_.

Note that when the PR is accepted all the commits on it (including the merge 
commits) will be squashed into a single commit that gets rebased onto the main 
branch -- so there is no danger of complicating the canonical history of the 
project. (And the local/internal history of a single PR is small enough that it 
will remain understandable even if there are merge commits from _main_.)

https://github.com/llvm/llvm-project/pull/136823
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to