https://github.com/pawosm-arm approved this pull request.

I've tried this patch and indeed I can build complete gromacs without compiler 
hanging on any part of its code.

One small comment (feel free to ignore if feels irrelevant): the 
`gmx_`-prefixed names used in the `noreturn-vars.cpp` test file clearly come 
from the gromacs project. It is open-sourced project so it shouldn't matter, 
but I wonder what the general rule is, can the names in the test cases refer 
back to the piece of software where the problem we test against originate from.


https://github.com/llvm/llvm-project/pull/150582
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to