Juan Manuel Martinez =?utf-8?q?Caamaño?= <juama...@amd.com>, Juan Manuel Martinez =?utf-8?q?Caamaño?= <juama...@amd.com>, Juan Manuel Martinez =?utf-8?q?Caamaño?Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/137...@github.com>
================ @@ -48,6 +48,7 @@ // instantiation for v<int> in one of the two headers, because we will only // parse one of the two get() functions. +#ifdef NS ---------------- AaronBallman wrote: @Bigcheese @ChuanqiXu9 are you okay with changing the modules test this way? It's unclear to me whether the original code was intentionally using preprocessor conditionals this way as part of the test, or just happenstance that's fine to change. https://github.com/llvm/llvm-project/pull/137665 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits