jyu2 added a comment. In https://reviews.llvm.org/D33333#770238, @aaron.ballman wrote:
> In https://reviews.llvm.org/D33333#768332, @jyu2 wrote: > > > Okay this CFG version of this change. In this change I am basic using same > > algorithm with -Winfinite-recursion. > > > > In addition to my original implementation, I add handler type checking > > which basic using https://reviews.llvm.org/D19201 method. > > > Thank you, I think this is a step in the right direction! > > > There are couple things I am worry about this implementation: > > 1> compile time... > > Do you have any timing data on whether this has a negative performance impact? > > > 2> Correctness... > > Your implementation looks reasonable to me, but with further review (and good > tests), we should have a better grasp on correctness. > > > 3> Stack overflow for large CFG... > > I would be surprised if that were a problem, but is something we could > address if it ever arises. Hope that is okay. https://reviews.llvm.org/D33333 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
