https://github.com/jthackray created https://github.com/llvm/llvm-project/pull/150054
As mentioned in https://discourse.llvm.org/t/rfc-rename-source-files-in-clang-lib-codegen-targetbuiltins/87462/ it appears that MacOS's libtool warns about source filenames that are identically named, even if they exist in separate directories. Sadly, there doesn't appear to be an easy way to disable this warning, so rename these files, as these warnings are annoying for MacOS users. Fixes #133199. >From b74d772aa18f0994d30379606f826e69c76c85bc Mon Sep 17 00:00:00 2001 From: Jonathan Thackray <jonathan.thack...@arm.com> Date: Tue, 22 Jul 2025 17:16:09 +0100 Subject: [PATCH] [clang] Rename files that MacOS libtool warns about (NFC) As mentioned in https://discourse.llvm.org/t/rfc-rename-source-files-in-clang-lib-codegen-targetbuiltins/87462/ it appears that MacOS's libtool warns about source filenames that are identically named, even if they exist in separate directories. Sadly, there doesn't appear to be an easy way to disable this warning, so rename these files, as these warnings are annoying for MacOS users. Fixes #133199. --- clang/lib/CodeGen/CMakeLists.txt | 22 +++++++++---------- .../{AMDGPU.cpp => BuiltinAMDGPU.cpp} | 2 +- .../{ARM.cpp => BuiltinARM.cpp} | 2 +- .../{DirectX.cpp => BuiltinDirectX.cpp} | 2 +- .../{Hexagon.cpp => BuiltinHexagon.cpp} | 2 +- .../{NVPTX.cpp => BuiltinNVPTX.cpp} | 2 +- .../{PPC.cpp => BuiltinPPC.cpp} | 2 +- .../{RISCV.cpp => BuiltinRISCV.cpp} | 2 +- .../{SPIR.cpp => BuiltinSPIR.cpp} | 2 +- .../{SystemZ.cpp => BuiltinSystemZ.cpp} | 2 +- ...WebAssembly.cpp => BuiltinWebAssembly.cpp} | 2 +- .../{X86.cpp => BuiltinX86.cpp} | 2 +- 12 files changed, 22 insertions(+), 22 deletions(-) rename clang/lib/CodeGen/TargetBuiltins/{AMDGPU.cpp => BuiltinAMDGPU.cpp} (99%) rename clang/lib/CodeGen/TargetBuiltins/{ARM.cpp => BuiltinARM.cpp} (99%) rename clang/lib/CodeGen/TargetBuiltins/{DirectX.cpp => BuiltinDirectX.cpp} (95%) rename clang/lib/CodeGen/TargetBuiltins/{Hexagon.cpp => BuiltinHexagon.cpp} (99%) rename clang/lib/CodeGen/TargetBuiltins/{NVPTX.cpp => BuiltinNVPTX.cpp} (99%) rename clang/lib/CodeGen/TargetBuiltins/{PPC.cpp => BuiltinPPC.cpp} (99%) rename clang/lib/CodeGen/TargetBuiltins/{RISCV.cpp => BuiltinRISCV.cpp} (99%) rename clang/lib/CodeGen/TargetBuiltins/{SPIR.cpp => BuiltinSPIR.cpp} (99%) rename clang/lib/CodeGen/TargetBuiltins/{SystemZ.cpp => BuiltinSystemZ.cpp} (99%) rename clang/lib/CodeGen/TargetBuiltins/{WebAssembly.cpp => BuiltinWebAssembly.cpp} (99%) rename clang/lib/CodeGen/TargetBuiltins/{X86.cpp => BuiltinX86.cpp} (99%) diff --git a/clang/lib/CodeGen/CMakeLists.txt b/clang/lib/CodeGen/CMakeLists.txt index 0f2a352886e7f..38bba115117da 100644 --- a/clang/lib/CodeGen/CMakeLists.txt +++ b/clang/lib/CodeGen/CMakeLists.txt @@ -117,17 +117,17 @@ add_clang_library(clangCodeGen PatternInit.cpp SanitizerMetadata.cpp SwiftCallingConv.cpp - TargetBuiltins/ARM.cpp - TargetBuiltins/AMDGPU.cpp - TargetBuiltins/DirectX.cpp - TargetBuiltins/Hexagon.cpp - TargetBuiltins/NVPTX.cpp - TargetBuiltins/PPC.cpp - TargetBuiltins/RISCV.cpp - TargetBuiltins/SPIR.cpp - TargetBuiltins/SystemZ.cpp - TargetBuiltins/WebAssembly.cpp - TargetBuiltins/X86.cpp + TargetBuiltins/BuiltinARM.cpp + TargetBuiltins/BuiltinAMDGPU.cpp + TargetBuiltins/BuiltinDirectX.cpp + TargetBuiltins/BuiltinHexagon.cpp + TargetBuiltins/BuiltinNVPTX.cpp + TargetBuiltins/BuiltinPPC.cpp + TargetBuiltins/BuiltinRISCV.cpp + TargetBuiltins/BuiltinSPIR.cpp + TargetBuiltins/BuiltinSystemZ.cpp + TargetBuiltins/BuiltinWebAssembly.cpp + TargetBuiltins/BuiltinX86.cpp TargetInfo.cpp Targets/AArch64.cpp Targets/AMDGPU.cpp diff --git a/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp b/clang/lib/CodeGen/TargetBuiltins/BuiltinAMDGPU.cpp similarity index 99% rename from clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp rename to clang/lib/CodeGen/TargetBuiltins/BuiltinAMDGPU.cpp index 7dccf82b1a7a3..677de2ee898a7 100644 --- a/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp +++ b/clang/lib/CodeGen/TargetBuiltins/BuiltinAMDGPU.cpp @@ -1,4 +1,4 @@ -//===------- AMDCPU.cpp - Emit LLVM Code for builtins ---------------------===// +//===------- BuiltinAMDCPU.cpp - Emit LLVM Code for builtins --------------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. diff --git a/clang/lib/CodeGen/TargetBuiltins/ARM.cpp b/clang/lib/CodeGen/TargetBuiltins/BuiltinARM.cpp similarity index 99% rename from clang/lib/CodeGen/TargetBuiltins/ARM.cpp rename to clang/lib/CodeGen/TargetBuiltins/BuiltinARM.cpp index 7e6a47fd7c103..327a8f5e29b27 100644 --- a/clang/lib/CodeGen/TargetBuiltins/ARM.cpp +++ b/clang/lib/CodeGen/TargetBuiltins/BuiltinARM.cpp @@ -1,4 +1,4 @@ -//===---------- ARM.cpp - Emit LLVM Code for builtins ---------------------===// +//===---------- BuiltinARM.cpp - Emit LLVM Code for builtins --------------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. diff --git a/clang/lib/CodeGen/TargetBuiltins/DirectX.cpp b/clang/lib/CodeGen/TargetBuiltins/BuiltinDirectX.cpp similarity index 95% rename from clang/lib/CodeGen/TargetBuiltins/DirectX.cpp rename to clang/lib/CodeGen/TargetBuiltins/BuiltinDirectX.cpp index 51202331bb779..32ec59f2ffdc5 100644 --- a/clang/lib/CodeGen/TargetBuiltins/DirectX.cpp +++ b/clang/lib/CodeGen/TargetBuiltins/BuiltinDirectX.cpp @@ -1,4 +1,4 @@ -//===--------- DirectX.cpp - Emit LLVM Code for builtins ------------------===// +//===--------- BuiltinDirectX.cpp - Emit LLVM Code for builtins -----------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. diff --git a/clang/lib/CodeGen/TargetBuiltins/Hexagon.cpp b/clang/lib/CodeGen/TargetBuiltins/BuiltinHexagon.cpp similarity index 99% rename from clang/lib/CodeGen/TargetBuiltins/Hexagon.cpp rename to clang/lib/CodeGen/TargetBuiltins/BuiltinHexagon.cpp index 26fe69536daa2..6204658b51985 100644 --- a/clang/lib/CodeGen/TargetBuiltins/Hexagon.cpp +++ b/clang/lib/CodeGen/TargetBuiltins/BuiltinHexagon.cpp @@ -1,4 +1,4 @@ -//===------ Hexagon.cpp - Emit LLVM Code for builtins ---------------------===// +//===------ BuiltinHexagon.cpp - Emit LLVM Code for builtins --------------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. diff --git a/clang/lib/CodeGen/TargetBuiltins/NVPTX.cpp b/clang/lib/CodeGen/TargetBuiltins/BuiltinNVPTX.cpp similarity index 99% rename from clang/lib/CodeGen/TargetBuiltins/NVPTX.cpp rename to clang/lib/CodeGen/TargetBuiltins/BuiltinNVPTX.cpp index 6da65b681df1e..34f81e2b2a3d0 100644 --- a/clang/lib/CodeGen/TargetBuiltins/NVPTX.cpp +++ b/clang/lib/CodeGen/TargetBuiltins/BuiltinNVPTX.cpp @@ -1,4 +1,4 @@ -//===-------- NVPTX.cpp - Emit LLVM Code for builtins ---------------------===// +//===-------- BuiltinNVPTX.cpp - Emit LLVM Code for builtins --------------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. diff --git a/clang/lib/CodeGen/TargetBuiltins/PPC.cpp b/clang/lib/CodeGen/TargetBuiltins/BuiltinPPC.cpp similarity index 99% rename from clang/lib/CodeGen/TargetBuiltins/PPC.cpp rename to clang/lib/CodeGen/TargetBuiltins/BuiltinPPC.cpp index 270e9fc976f23..c2bef235ad5a1 100644 --- a/clang/lib/CodeGen/TargetBuiltins/PPC.cpp +++ b/clang/lib/CodeGen/TargetBuiltins/BuiltinPPC.cpp @@ -1,4 +1,4 @@ -//===---------- PPC.cpp - Emit LLVM Code for builtins ---------------------===// +//===---------- BuiltinPPC.cpp - Emit LLVM Code for builtins --------------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. diff --git a/clang/lib/CodeGen/TargetBuiltins/RISCV.cpp b/clang/lib/CodeGen/TargetBuiltins/BuiltinRISCV.cpp similarity index 99% rename from clang/lib/CodeGen/TargetBuiltins/RISCV.cpp rename to clang/lib/CodeGen/TargetBuiltins/BuiltinRISCV.cpp index b08a0588c5ac1..a6f49e9b9106e 100644 --- a/clang/lib/CodeGen/TargetBuiltins/RISCV.cpp +++ b/clang/lib/CodeGen/TargetBuiltins/BuiltinRISCV.cpp @@ -1,4 +1,4 @@ -//===-------- RISCV.cpp - Emit LLVM Code for builtins ---------------------===// +//===-------- BuiltinRISCV.cpp - Emit LLVM Code for builtins --------------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. diff --git a/clang/lib/CodeGen/TargetBuiltins/SPIR.cpp b/clang/lib/CodeGen/TargetBuiltins/BuiltinSPIR.cpp similarity index 99% rename from clang/lib/CodeGen/TargetBuiltins/SPIR.cpp rename to clang/lib/CodeGen/TargetBuiltins/BuiltinSPIR.cpp index 243aad8bf7083..7cd0535b5a319 100644 --- a/clang/lib/CodeGen/TargetBuiltins/SPIR.cpp +++ b/clang/lib/CodeGen/TargetBuiltins/BuiltinSPIR.cpp @@ -1,4 +1,4 @@ -//===--------- SPIR.cpp - Emit LLVM Code for builtins ---------------------===// +//===--------- BuiltinSPIR.cpp - Emit LLVM Code for builtins --------------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. diff --git a/clang/lib/CodeGen/TargetBuiltins/SystemZ.cpp b/clang/lib/CodeGen/TargetBuiltins/BuiltinSystemZ.cpp similarity index 99% rename from clang/lib/CodeGen/TargetBuiltins/SystemZ.cpp rename to clang/lib/CodeGen/TargetBuiltins/BuiltinSystemZ.cpp index a7c25b29d1dba..527d763bb6315 100644 --- a/clang/lib/CodeGen/TargetBuiltins/SystemZ.cpp +++ b/clang/lib/CodeGen/TargetBuiltins/BuiltinSystemZ.cpp @@ -1,4 +1,4 @@ -//===------ SystemZ.cpp - Emit LLVM Code for builtins ---------------------===// +//===------ BuiltinSystemZ.cpp - Emit LLVM Code for builtins --------------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. diff --git a/clang/lib/CodeGen/TargetBuiltins/WebAssembly.cpp b/clang/lib/CodeGen/TargetBuiltins/BuiltinWebAssembly.cpp similarity index 99% rename from clang/lib/CodeGen/TargetBuiltins/WebAssembly.cpp rename to clang/lib/CodeGen/TargetBuiltins/BuiltinWebAssembly.cpp index b7fd70e855d40..e5f4f2c6e57c2 100644 --- a/clang/lib/CodeGen/TargetBuiltins/WebAssembly.cpp +++ b/clang/lib/CodeGen/TargetBuiltins/BuiltinWebAssembly.cpp @@ -1,4 +1,4 @@ -//===-- WebAssembly.cpp - Emit LLVM Code for builtins ---------------------===// +//===-- BuiltinWebAssembly.cpp - Emit LLVM Code for builtins --------------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. diff --git a/clang/lib/CodeGen/TargetBuiltins/X86.cpp b/clang/lib/CodeGen/TargetBuiltins/BuiltinX86.cpp similarity index 99% rename from clang/lib/CodeGen/TargetBuiltins/X86.cpp rename to clang/lib/CodeGen/TargetBuiltins/BuiltinX86.cpp index e23d19d2f6b6b..4bcf572bc9025 100644 --- a/clang/lib/CodeGen/TargetBuiltins/X86.cpp +++ b/clang/lib/CodeGen/TargetBuiltins/BuiltinX86.cpp @@ -1,4 +1,4 @@ -//===---------- X86.cpp - Emit LLVM Code for builtins ---------------------===// +//===---------- BuiltinX86.cpp - Emit LLVM Code for builtins --------------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
