================
@@ -8392,17 +8392,19 @@ def ext_default_init_const : ExtWarn<
   "is a Microsoft extension">,
   InGroup<MicrosoftConstInit>;
 def err_delete_operand : Error<"cannot delete expression of type %0">;
+def err_delete_void_ptr_operand : Error<
+  "cannot delete expression with pointer-to-'void' type %0">;
 def ext_delete_void_ptr_operand : ExtWarn<
   "cannot delete expression with pointer-to-'void' type %0">,
   InGroup<DeleteIncomplete>;
 def err_ambiguous_delete_operand : Error<
   "ambiguous conversion of delete expression of type %0 to a pointer">;
 def warn_delete_incomplete : Warning<
-  "deleting pointer to incomplete type %0 is incompatible with C++2c"
+  "deleting pointer to incomplete %select{struct|union}0 %1 is incompatible 
with C++2c"
----------------
hvdijk wrote:

> That said, I don't see the value in saying anything other than incomplete 
> type.

My reason for wanting to change the diagnostic is that the diagnostic is 
telling users that it is an error to delete a pointer to an incomplete type 
when that is not the case.

That said, I'd be okay with taking the diagnostic changes out of this PR and 
leaving this as just the fix for the rejects-valid. We can figure out whether 
we can come up with improved wording in a separate PR.

https://github.com/llvm/llvm-project/pull/149406
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to