rogfer01 added inline comments.

================
Comment at: lib/AST/ItaniumMangle.cpp:2210
+  if (Quals.hasUnaligned())
+      mangleVendorQualifier("__unaligned");
+
----------------
rsmith wrote:
> Too much indentation here. Also, the ABI requires the "unordered" vendor 
> qualifiers to be emitted in reverse alphabetical order, so this should be 
> emitted after `__weak` and `__strong` but before `__autoreleasing`.
I think you meant after `__weak` but before `__strong` and `__autoreleasing`? 
Maybe I'm misinterpreting something here.

The current patch emits `__weak`, then `__unaligned` and then the remaining ARC 
ones.


https://reviews.llvm.org/D33398



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to