llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Aaron Danen (aadanen) <details> <summary>Changes</summary> Hi all. This is my first pull request to an open source project. I am a student so have mercy on me! I have done my best to read all of the relevant documentation about how to contribute most effectively but its totally possible I've made a mistake or missed something. Please let me know so I can do better next time :) I found a simple issue and have done my best to resolve it. I believe this change resolves #<!-- -->143668 All i did was grep -r "Too many undos" and replace all instances of that string with the suggested replacement. thank you for your time aadanen --- Full diff: https://github.com/llvm/llvm-project/pull/149396.diff 2 Files Affected: - (modified) clang/lib/Interpreter/Interpreter.cpp (+1-1) - (modified) clang/unittests/Interpreter/InterpreterTest.cpp (+2-2) ``````````diff diff --git a/clang/lib/Interpreter/Interpreter.cpp b/clang/lib/Interpreter/Interpreter.cpp index ed3bae59a144c..a2696f78cb510 100644 --- a/clang/lib/Interpreter/Interpreter.cpp +++ b/clang/lib/Interpreter/Interpreter.cpp @@ -754,7 +754,7 @@ llvm::Error Interpreter::Undo(unsigned N) { if (N > getEffectivePTUSize()) return llvm::make_error<llvm::StringError>("Operation failed. " - "Too many undos", + "No input left to undo", std::error_code()); for (unsigned I = 0; I < N; I++) { if (IncrExecutor) { diff --git a/clang/unittests/Interpreter/InterpreterTest.cpp b/clang/unittests/Interpreter/InterpreterTest.cpp index b97f5ae17c9f0..2ec65e2a9b2ef 100644 --- a/clang/unittests/Interpreter/InterpreterTest.cpp +++ b/clang/unittests/Interpreter/InterpreterTest.cpp @@ -158,12 +158,12 @@ TEST_F(InterpreterTest, UndoCommand) { // Fail to undo. auto Err1 = Interp->Undo(); - EXPECT_EQ("Operation failed. Too many undos", + EXPECT_EQ("Operation failed. No input left to undo", llvm::toString(std::move(Err1))); auto Err2 = Interp->Parse("int foo = 42;"); EXPECT_TRUE(!!Err2); auto Err3 = Interp->Undo(2); - EXPECT_EQ("Operation failed. Too many undos", + EXPECT_EQ("Operation failed. No input left to undo", llvm::toString(std::move(Err3))); // Succeed to undo. `````````` </details> https://github.com/llvm/llvm-project/pull/149396 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
