https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/148338
NumElts, a member variable of ArrayTypeInfo, is already of Expr *.
>From 77284e1f4832ed648fce11ea3cb877369efcf20e Mon Sep 17 00:00:00 2001
From: Kazu Hirata <k...@google.com>
Date: Fri, 11 Jul 2025 11:20:17 -0700
Subject: [PATCH] [Sema] Remove unnecessary casts (NFC)
NumElts, a member variable of ArrayTypeInfo, is already of Expr *.
---
clang/lib/Sema/SemaExprCXX.cpp | 4 ++--
clang/lib/Sema/SemaType.cpp | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp
index f17a338825423..5dca34c04a71b 100644
--- a/clang/lib/Sema/SemaExprCXX.cpp
+++ b/clang/lib/Sema/SemaExprCXX.cpp
@@ -2021,7 +2021,7 @@ Sema::ActOnCXXNew(SourceLocation StartLoc, bool UseGlobal,
return ExprError(Diag(Chunk.Loc, diag::err_array_new_needs_size)
<< D.getSourceRange());
- ArraySize = static_cast<Expr*>(Chunk.Arr.NumElts);
+ ArraySize = Chunk.Arr.NumElts;
D.DropFirstTypeObject();
}
@@ -2032,7 +2032,7 @@ Sema::ActOnCXXNew(SourceLocation StartLoc, bool UseGlobal,
break;
DeclaratorChunk::ArrayTypeInfo &Array = D.getTypeObject(I).Arr;
- if (Expr *NumElts = (Expr *)Array.NumElts) {
+ if (Expr *NumElts = Array.NumElts) {
if (!NumElts->isTypeDependent() && !NumElts->isValueDependent()) {
// FIXME: GCC permits constant folding here. We should either do so
consistently
// or not do so at all, rather than changing behavior in C++14
onwards.
diff --git a/clang/lib/Sema/SemaType.cpp b/clang/lib/Sema/SemaType.cpp
index 88aa63d3b9e83..661746731fdcc 100644
--- a/clang/lib/Sema/SemaType.cpp
+++ b/clang/lib/Sema/SemaType.cpp
@@ -4727,7 +4727,7 @@ static TypeSourceInfo
*GetFullTypeForDeclarator(TypeProcessingState &state,
// Build the type anyway.
}
DeclaratorChunk::ArrayTypeInfo &ATI = DeclType.Arr;
- Expr *ArraySize = static_cast<Expr*>(ATI.NumElts);
+ Expr *ArraySize = ATI.NumElts;
ArraySizeModifier ASM;
// Microsoft property fields can have multiple sizeless array chunks
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
