sbenza added inline comments.
================ Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:31 + isAnyPointer(), + references(type()), + templateTypeParmType(), ---------------- References are never const qualified, right? ================ Comment at: test/clang-tidy/readability-const-value-return.cpp:51 +const T f_returns_template_param(); + +template <typename T> ---------------- We are missing one like: template <typename T> T f(); where `T` is `const X`. We also need to test for macros (and skip fixes there) Repository: rL LLVM https://reviews.llvm.org/D33531 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits