kikairoya wrote:

> I tested this and it broke things for me. This turns cygLLVM-20.dll into a 
> symlink, this doesn't work with existing binaries because DLLs in the import 
> table can't follow the Cygwin symlinks (they're loaded by the Windows 
> loader). It looks like for new binaries it does end up linking to 
> cygLLVM-20.1.dll which is the actual file.

Thank you for testing.
Then, cygLLVM-20.dll must be a regular file.
Other DLLs should also provide a regular file without minor version. I think 
existing binaries will be broken at every minor version up of LLVM.

> Also, I may have screwed something up, but I'm not getting the libclang 
> symlink in the install (only in the build dir).

Oops. I'll retry.


https://github.com/llvm/llvm-project/pull/147132
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to