On some Windows bots, multiple back slashes are used as a single path separator so the path looks like:
build_dir\\\\bin\\\\clang PREFIX_DIR would match "build_dir\\\\bin\\", the path separator matches "\", then the directory would match the empty string, and the final path separator would match the "\" before clang. On Mon, May 29, 2017 at 11:18 AM, David Blaikie <dblai...@gmail.com> wrote: > Why would matching on an empty string be bad in this case? > > On Thu, May 25, 2017 at 4:25 PM Richard Trieu via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rtrieu >> Date: Thu May 25 18:25:36 2017 >> New Revision: 303934 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=303934&view=rev >> Log: >> "*" => "+" to avoid matching on empty string. >> >> Modified: >> cfe/trunk/test/Driver/baremetal.cpp >> >> Modified: cfe/trunk/test/Driver/baremetal.cpp >> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/ba >> remetal.cpp?rev=303934&r1=303933&r2=303934&view=diff >> ============================================================ >> ================== >> --- cfe/trunk/test/Driver/baremetal.cpp (original) >> +++ cfe/trunk/test/Driver/baremetal.cpp Thu May 25 18:25:36 2017 >> @@ -4,7 +4,7 @@ >> // RUN: -L some/directory/user/asked/for \ >> // RUN: --sysroot=%S/Inputs/baremetal_arm \ >> // RUN: | FileCheck --check-prefix=CHECK-V6M-C %s >> -// CHECK-V6M-C: "[[PREFIX_DIR:.*]]{{[/\\]+}}{{ >> [^/^\\]*}}{{[/\\]+}}clang{{.*}}" "-cc1" "-triple" "thumbv6m-none--eabi" >> +// CHECK-V6M-C: "[[PREFIX_DIR:.*]]{{[/\\]+}}{{ >> [^/^\\]+}}{{[/\\]+}}clang{{.*}}" "-cc1" "-triple" "thumbv6m-none--eabi" >> // CHECK-V6M-C-SAME: "-resource-dir" "[[PREFIX_DIR]]{{[/\\]+}}lib{{ >> [/\\]+}}clang{{[/\\]+}}[[VERSION:[^"]*]]" >> // CHECK-V6M-C-SAME: "-isysroot" "[[SYSROOT:[^"]*]]" >> // CHECK-V6M-C-SAME: "-internal-isystem" "[[SYSROOT]]{{[/\\]+}}include{ >> {[/\\]+}}c++{{[/\\]+}}v1" >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
