Prazek marked an inline comment as done.
Prazek added inline comments.
================
Comment at: include/clang/AST/VTableBuilder.h:169
+ return GlobalDecl(DtorDecl, CXXDtorType::Dtor_Deleting);
+ default:
+ llvm_unreachable("Only function pointers kinds");
----------------
rjmccall wrote:
> By "exhaustive" I mean that you should list out all the cases instead of
> using default. It means that someone who adds a new kind of v-table entry
> will get alerted to fix this switch. There's only five other cases, it's not
> too bad.
Oh right, that make sense
https://reviews.llvm.org/D33437
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
