https://github.com/zmodem requested changes to this pull request.
> I'll land this one week later if no objection or new comments come in
I object.
Even the author seems to object:
> I believe it is now incorrect to use /Fo for the BMI output
The change to `Driver::GetNamedOutputPath` has not been explained yet, beyond
"it seems to make the tests pass".
And the whole approach of making clang-cl's `/Fo` ("set object file noame") to
something different from MSVC's seems very questionable.
I think this patch needs to go back to the drawing board.
https://github.com/llvm/llvm-project/pull/121046
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
