llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Rob Buis (rwlbuis) <details> <summary>Changes</summary> CFEqual is a trivial function, so treat it as safe. --- Full diff: https://github.com/llvm/llvm-project/pull/146369.diff 3 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefCallArgsChecker.cpp (+1-1) - (added) clang/test/Analysis/Checkers/WebKit/call-args-safe-functions.mm (+11) - (modified) clang/test/Analysis/Checkers/WebKit/objc-mock-types.h (+1) ``````````diff diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefCallArgsChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefCallArgsChecker.cpp index 6bc39ab565041..764e2c640feb8 100644 --- a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefCallArgsChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefCallArgsChecker.cpp @@ -294,7 +294,7 @@ class RawPtrRefCallArgsChecker if (name == "adoptRef" || name == "getPtr" || name == "WeakPtr" || name == "is" || name == "equal" || name == "hash" || name == "isType" || // FIXME: Most/all of these should be implemented via attributes. - name == "equalIgnoringASCIICase" || + name == "CFEqual" || name == "equalIgnoringASCIICase" || name == "equalIgnoringASCIICaseCommon" || name == "equalIgnoringNullity" || name == "toString") return true; diff --git a/clang/test/Analysis/Checkers/WebKit/call-args-safe-functions.mm b/clang/test/Analysis/Checkers/WebKit/call-args-safe-functions.mm new file mode 100644 index 0000000000000..c1ce08d0b10f6 --- /dev/null +++ b/clang/test/Analysis/Checkers/WebKit/call-args-safe-functions.mm @@ -0,0 +1,11 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s + +#include "objc-mock-types.h" + +CGImageRef provideImage(); + +Boolean cfe(CFTypeRef obj) +{ + return CFEqual(obj, provideImage()); +} + diff --git a/clang/test/Analysis/Checkers/WebKit/objc-mock-types.h b/clang/test/Analysis/Checkers/WebKit/objc-mock-types.h index 9e4356a71f1b5..cd2f53a8ec9c5 100644 --- a/clang/test/Analysis/Checkers/WebKit/objc-mock-types.h +++ b/clang/test/Analysis/Checkers/WebKit/objc-mock-types.h @@ -45,6 +45,7 @@ CFDictionaryRef CFDictionaryCreateCopy(CFAllocatorRef allocator, CFDictionaryRef CFDictionaryRef CFDictionaryCreateMutableCopy(CFAllocatorRef allocator, CFIndex capacity, CFDictionaryRef theDict); CFIndex CFDictionaryGetCount(CFDictionaryRef theDict); Boolean CFDictionaryContainsKey(CFDictionaryRef theDict, const void *key); +extern Boolean CFEqual(CFTypeRef, CFTypeRef); Boolean CFDictionaryContainsValue(CFDictionaryRef theDict, const void *value); const void *CFDictionaryGetValue(CFDictionaryRef theDict, const void *key); void CFDictionaryAddValue(CFMutableDictionaryRef theDict, const void *key, const void *value); `````````` </details> https://github.com/llvm/llvm-project/pull/146369 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
