echristo accepted this revision. echristo added a comment. Couple of small nits and a request to make some of the change separately, but otherwise LGTM. For the split part please don't actually submit another patch, just go ahead and do it :)
Thanks! -eric ================ Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8007 +def err_vsx_builtin_nonconstant_argument : Error< + "argument %0 to %1 must be a 2-bit unsigned literal (i.e. 0,1,2 or 3)">; +def err_vec_builtin_non_vector : Error< ---------------- Spaces after commas please. ================ Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8014-8017 +def err_vec_builtin_non_vector : Error< + "first two arguments to %0 must be vectors">; +def err_vec_builtin_incompatible_vector : Error< + "first two arguments to %0 must have the same type">; ---------------- The name change can be done separately. https://reviews.llvm.org/D33053 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
